search

omnilight / yii2-scheduling

Scheduling extension for Yii2 framework
MIT License
315 stars 83 forks source link

Update ScheduleController.php #66

Closed acto-felix closed 2 years ago

acto-felix commented 4 years ago

Correction on if statement to be concise with all code and changing className() to class as the former is deprecated

kstkn commented 4 years ago

Please note that ::class special constant was introduced in 5.5, this change is breaking compatibility with php 5.4

acto-felix commented 4 years ago

@kstkn unfortunately yes, but php 5.4 does not even have security support anymore as it has reached its end of life some years ago (I believe it was 2015), so it should be fine for the majority of cases.

kstkn commented 4 years ago

I'm not telling that php 5.4 should be supported. However if support for it going to be dropped it should be handled with care: composer.json updated, library version properly incremented, and so on