search

omniosorg / omnios-extra

Packages for OmniOS extra
https://omnios.org
Other
26 stars 58 forks source link

sdns: Add new package to repo #1457

Open justledbetter opened 1 month ago

justledbetter commented 1 month ago

I've added the sdns package (https://github.com/semihalev/sdns) to the repo, and confirmed it builds and appears to startup/shutdown correctly. This is my first attempt at doing any of this, so please forgive me if anything is amiss! :)

justledbetter commented 1 month ago

Im sorry, I scavenged through gh and mattermost and nsd to piece together all the moving parts for this!

This is what I get for keeping changes to a minimal.. 😅

Sent via BlackBerry Hub+ Inbox for Androidhttp://play.google.com/store/apps/details?id=com.blackberry.hub From: @. Sent: May 15, 2024 06:34 To: @. Reply-to: @. Cc: @.; @.*** Subject: Re: [omniosorg/omnios-extra] sdns: Add new package to repo (PR #1457)

@gkoh commented on this pull request.

In build/sdns/local.moghttps://github.com/omniosorg/omnios-extra/pull/1457#discussion_r1601386405:

@@ -0,0 +1,26 @@ +# +# This file and its contents are supplied under the terms of the +# Common Development and Distribution License ("CDDL"), version 1.0. +# You may only use this file in accordance with the terms of version +# 1.0 of the CDDL. +# +# A full copy of the text of the CDDL should have accompanied this +# source. A copy of the CDDL is also available via the Internet at +# http://www.illumos.org/license/CDDL. + +# Copyright 2024 Guo-Rong Koh

Hmm, I don't remember writing this 😂

— Reply to this email directly, view it on GitHubhttps://github.com/omniosorg/omnios-extra/pull/1457#pullrequestreview-2057584529, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADF4KZP3A555LTPQIY3SY23ZCM23BAVCNFSM6AAAAABHWGJR6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJXGU4DINJSHE. You are receiving this because you authored the thread.Message ID: @.***>

gkoh commented 1 month ago

Im sorry, I scavenged through gh and mattermost and nsd to piece together all the moving parts for this! This is what I get for keeping changes to a minimal.. 😅

No problems! Happy that my contribution was helpful to you :slightly_smiling_face:

oetiker commented 1 month ago

ping @hadfl

oetiker commented 1 week ago

@gkoh ping

gkoh commented 1 week ago

@gkoh ping

Sorry, this is not my PR. I only commented because my name was 'used in vain'.

oetiker commented 1 week ago

@justledbetter ping!

justledbetter commented 6 days ago

Apologies, have been out of town! Will get back on this shortly!

justledbetter commented 6 days ago

Thanks again to everyone for your feedback, and most importantly for your patience! Hopefully things look better after the latest commits :)

hadfl commented 4 days ago

I think you have overlooked the comments regarding removing print_config which seems to be a leftover from another build where you copied from and also adding this package to doc/packages.md and doc/baseline.

Sorry again, that getting back to this review took so long.