search

omniphx / forrest

A Laravel library for Salesforce
https://omniphx.github.io/forrest/
MIT License
259 stars 120 forks source link

Added git hub action support #267

Closed grantjanecek closed 4 years ago

grantjanecek commented 4 years ago

This will auto run the test suite

omniphx commented 4 years ago

This looks great! One thing I just noticed is that the phpspec test script doesn't actually run. Just outputs the version details.

Should be an easy fix: run: vendor/bin/phpspec > run: vendor/bin/phpspec run

omniphx commented 4 years ago

Also, feel free to remove the .travis.yml

grantjanecek commented 4 years ago

Ah oops, that makes sense. I'm used to phpunit.

I have been getting this issue when running the suite. Have any recommendations on resolving this? Do I need to be connected to a sandbox SF instance to run tests?

Run vendor/bin/phpspec run / skipped: 0% / pending: 0% / passed: 100% / failed: 0% / broken: 0% / 1 examples Omniphx/Forrest/Authentications/OAuthJWT 188 - it should authenticate exception [err:TypeError("Return value of Double\ClientInterface\ClientInterface\P10::request() must implement interface Psr\Http\Message\ResponseInterface, null returned")] has been thrown. Omniphx/Forrest/Authentications/OAuthJWT 246 - it should refresh exception [err:TypeError("Return value of Double\ClientInterface\ClientInterface\P10::request() must implement interface Psr\Http\Message\ResponseInterface, null returned")] has been thrown. / skipped: 0% / pending: 0% / passed: 98% / failed: 0% / broken: 1% / 126 examples 16 specs 126 examples (124 passed, 2 broken) 117ms

On Fri, Oct 2, 2020 at 10:33 AM Marty notifications@github.com wrote:

Also, feel free to remove the .travis.yml

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/omniphx/forrest/pull/267#issuecomment-702769204, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEC72OOZQRCK6DYPWPD6A2TSIXQFHANCNFSM4SAYEDEQ .

--

P Go Green! Please print this email only when necessary. Thank you for being environmentally responsible.

omniphx commented 4 years ago

Yup, started happening after merging JWT authentication #266. Didn't realize there were test errors until after I merged. Been meaning to address it so I can bump the version. Feel to include the changes

omniphx commented 4 years ago

@K03413R just FYI fixed the tests and updated the workflow in #269

Dealing with those tests is making regret going with PHPSpec. In hindsight, should have stuck with PHPUnit.

grantjanecek commented 4 years ago

Awesome. Thanks. I was in the middle of it, but was battling phpspec. then all hell broke loose at work last week.

On Sun, Oct 4, 2020 at 8:34 PM Marty notifications@github.com wrote:

@K03413R https://github.com/K03413R just FYI fixed the tests and updated the workflow to run the tests in #269 https://github.com/omniphx/forrest/pull/269

Dealing with those tests is making regret going with PHPSpec. In hindsight, should have stuck with PHPUnit.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/omniphx/forrest/pull/267#issuecomment-703339811, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEC72OME2PKQFXI5DEH65ADSJEH7TANCNFSM4SAYEDEQ .

--

P Go Green! Please print this email only when necessary. Thank you for being environmentally responsible.