search

omniscale / imposm3

Imposm imports OpenStreetMap data into PostGIS
http://imposm.org/docs/imposm3/latest/
Apache License 2.0
723 stars 158 forks source link

Fix compatibility with PostGIS 3.0 #248

Closed amatissart closed 4 years ago

amatissart commented 4 years ago

In https://github.com/omniscale/imposm3/commit/e29be21f51bff9228585ff753c912f48e6663d3e, calling populateGeometryColumn was limited to PostGIS versions != 2. It seems that the initial intention was to limit this call to all PostGIS versions < 2, the only versions where it's necessary.

So this PR suggests to update the condition to get the same behavior with PostGIS 2.x and 3.0.

amatissart commented 4 years ago

Note that some tests are failing in https://github.com/omniscale/imposm3/blob/master/import_/state_test.go (including on "master"). This is probably because the sequence numbers used in the tests are no longer consistent with osm.org

olt commented 4 years ago

Thanks! And yes, the tests are failing because maintenance work on the planet server shifted the sequence numbers. I just pushed a fix.