Patch changeListener to better sync self.current

omniscientjs / immstruct

Immutable data structures with history for top-to-bottom properties in component based libraries like React. Based on Immutable.js

374 stars 21 forks source link

Patch changeListener to better sync self.current #13

Closed dashed closed 9 years ago

dashed commented 9 years ago

Patch changeListener to better sync self.current when it's out of sync and when it's not.

[x] needs tests
[x] revised tests
[x] review tests and implementation

Closes https://github.com/omniscientjs/immstruct/issues/12

dashed commented 9 years ago

rebased and squashed commits.

dashed commented 9 years ago

I'm currently revising tests.

mikaelbr commented 9 years ago

Need to check this out, but immediately LGTM. The changes seem to make sense. I'll need to make a local copy and check it out with different test cases though. Maybe revise some tests.

dashed commented 9 years ago

I revised the tests. Feel free to change them for the better.

mikaelbr commented 9 years ago

Good job. :+1: I'll look more into it later today, when I'm not so occupied and distracted.