Pass in keyPath for swap and next-animation-frame events

omniscientjs / immstruct

Immutable data structures with history for top-to-bottom properties in component based libraries like React. Based on Immutable.js

374 stars 21 forks source link

Closed dashed closed 9 years ago

dashed commented 9 years ago

Surprised it doesn't do this.

Pass in keyPath for swap andnext-animation-frame events to better match onChange?: (newValue: any, oldValue?: any, keyPath?: Array<any>) => any signature for Cursors: https://github.com/facebook/immutable-js/blob/7cd0bc61b6552e88626587be4ff4adc5a9759c5a/contrib/cursor/index.d.ts#L44-L57

dashed commented 9 years ago

Will PR for this from my immstruct fork.

mikaelbr commented 9 years ago

Fixed in 97e250a24c325f44e349fd18abcf3766d707e469

singggum3b commented 9 years ago

still missing keypath in 'next-animation-frame' event?