Assigning arguments causes build error

omniscientjs / immstruct

Immutable data structures with history for top-to-bottom properties in component based libraries like React. Based on Immutable.js

374 stars 21 forks source link

Assigning arguments causes build error #46

Closed frederickfogerty closed 9 years ago

frederickfogerty commented 9 years ago

The declaration of var arguments causes a build error because it is a strict violation.

https://github.com/omniscientjs/immstruct/blob/master/src/structure.js#L453

Module build failed: SyntaxError: /Users/frederickf/Programming/react-d3/node_modules/immstruct/src/structure.js: Binding arguments in strict mode (260:6)

dashed commented 9 years ago

@frederickfogerty Mind sending PR?

frederickfogerty commented 9 years ago

Sure, can do.

frederickfogerty commented 9 years ago

Done, I'm loving this repo btw! And I somehow made a PR on my own fork as well (－‸ლ)