omniscientjs / immstruct

Immutable data structures with history for top-to-bottom properties in component based libraries like React. Based on Immutable.js
374 stars 21 forks source link

Remove uses of reserved word arguments #47

Closed frederickfogerty closed 9 years ago

frederickfogerty commented 9 years ago

Closes #46

dashed commented 9 years ago

Wondering if it's worth inserting 'use strict'; like this guy does for all of his npm modules: https://github.com/sindresorhus

frederickfogerty commented 9 years ago

Browserify can do that for you, I think.

https://www.npmjs.com/package/strictify

Alternatively you can do it manually

mikaelbr commented 9 years ago

Good change! Some how 'var arguments' slipped our review. You could use "info.arguments", but theres no reason when using "args" as name else where

frederickfogerty commented 9 years ago

@mikaelbr you could use info.arguments, and initially I just changed the variable internally in the function, but then decided that it's just good practice not to use arguments when it's not referencing the reserved word arguments, and so changed the other occurrences of the property/word.

mikaelbr commented 9 years ago

Yeah, I agree.