search

omniscientjs / immstruct

Immutable data structures with history for top-to-bottom properties in component based libraries like React. Based on Immutable.js
374 stars 21 forks source link

immutable-js/contrib/cursor has been deprecated #89

Closed neftaly closed 7 years ago

neftaly commented 7 years ago

immutable-js/contrib/cursor has been deprecated.

Suggest forking it, or replacing contrib/cursor with something from userland.

mikaelbr commented 7 years ago

It looks like https://github.com/redbadger/immutable-cursor can be a good substitute for the contrib implementation. Just need to find what the differences in API are. Hopefully, tests will catch any breaking change from our part, but this is never the less a breaking change of Immstruct.

If you want to send a PR with immutable-cursor that would be great!

neftaly commented 7 years ago

I tried updating immstruct to use immutable-cursor before making this issue, but there were a few incompatibilities. I have started making some PRs to get things going.

mikaelbr commented 7 years ago

Great stuff!

jameshopkins commented 7 years ago

Awesome that you guys are looking at potentially using immutable-cursor 👍

I tried updating immstruct to use immutable-cursor before making this issue, but there were a few incompatibilities

What type of incompatibilities were you experiencing? The only real difference in interface between contrib/cursor and immutable-cursor from what I can remember, is described in the documentation. I'd be more than happy to help where I can with the preliminary integration.

neftaly commented 7 years ago

Just paths, I think - https://github.com/redbadger/immutable-cursor/pull/15

neftaly commented 7 years ago

Immstruct passes all tests with immutable-cursor + the PR above :)

mikaelbr commented 7 years ago

Good job!