omniti-labs / omnios-build

Build system for OmniOS - Note, this is a quasi-private archive for OmniTI, you probably want https://omniosce.org
Other
39 stars 136 forks source link

build tmux against ncurses #68

Closed lotheac closed 9 years ago

lotheac commented 9 years ago

Fixes #67.

I didn't look very deeply into the underlying issue, but I've run into enough issues with the "system" libcurses that I've developed a disdain for it. Could be that tmux is assuming something about curses that's not true with libcurses, but in any case using ncurses instead fixes it. It probably also supports newer terminals better, but I'm just assuming. Maybe it's a bit of a blunt approach -- you're of course free to explore the issue further if you want to keep using libcurses in tmux instead ;)

I'd like to see this issue fixed in 151014 too, because it's a rather nasty bug.

danmcd commented 9 years ago

I'll add it to the next-014 list. Thanks!

lotheac commented 9 years ago

On Wed, Oct 14 2015 04:32:08 -0700, Dan McDonald wrote:

I'll add it to the next-014 list. Thanks!

Great. The patch applies cleanly to 1.9a (on r151014 branch) as well, but I didn't actually try it on 151014, so keep that in mind.

Running: gpatch -p1 -t -N -p0 patching file configure Hunk #1 succeeded at 4975 (offset -27 lines). --- Applied patch use-ncurses.patch

Lauri Tirkkonen | lotheac @ IRCnet