omniti-labs / omnios-build

Build system for OmniOS - Note, this is a quasi-private archive for OmniTI, you probably want https://omniosce.org
Other
39 stars 136 forks source link

add openssh locale patch from joyent/illumos-extra #74

Closed lotheac closed 8 years ago

lotheac commented 8 years ago

New sessions don't inherit LANG or LC_* from the daemon without this patch. AcceptEnv configuration works for the most part, but if a client does not specify its locale configuration then it will get none. SunSSH inherited these from the daemon if the client didn't specify, and that still makes sense.

danmcd commented 8 years ago

I was looking at how much of those joyent/illumos-extra patches to take. Sucking them ALL in breaks the build in ways I can't quite grok yet. OTOH, taking ones I know work is a much simpler task. Thank you.

lotheac commented 8 years ago

On Thu, Nov 19 2015 06:00:07 -0800, Dan McDonald wrote:

I was looking at how much of those joyent/illumos-extra patches to take. Sucking them ALL in breaks the build in ways I can't quite grok yet. OTOH, taking ones I know work is a much simpler task. Thank you.

I had to modify this one too, it didn't apply cleanly because the man page section renaming patches are a bit different.

0003-lastlogin.patch was another candidate I was taking a look at but given the fact that I'm working on lastlog improvements in-gate I didn't want to apply that one yet (the comment in there claims pam_unix_session will read lastlog, but that's untrue in illumos at the moment).

Maybe the PAM patches are worth looking at at least.

Lauri Tirkkonen | lotheac @ IRCnet

danmcd commented 8 years ago

Yeah, the PAM ones for sure. Someone was complaining about GSSAPI not working in OpenSSH like it does in SunSSH.

lotheac commented 8 years ago

On Thu, Nov 19 2015 06:09:43 -0800, Dan McDonald wrote:

Yeah, the PAM ones for sure. Someone was complaining about GSSAPI not working in OpenSSH like it does in SunSSH.

'UsePAM yes' fixes krb5 for me at least, but I guess there might be subtleties.

Lauri Tirkkonen | lotheac @ IRCnet