Revised logging and added upload-logs command

omnivector-solutions / jobbergate-cli

Jobbergate CLI

MIT License

2 stars 0 forks source link

Revised logging and added upload-logs command #88

Closed dusktreader closed 2 years ago

dusktreader commented 3 years ago

Added a bunch of debug logging via loguru
Added an option to show all log messages (--verbose) in the cli
Added a rotating file handler for logs that saves in HOME
Added a command to log out (remove auth token)
Moved arg descriptions to --help options
Added logging of user, command, and args

heitorPB commented 2 years ago

@dusktreader where is this "latest commit" that you mentioned a few times?

Could you please stop squashing your commits while we review the code? This pull request is already insanely long (~1k LOC). Having to over all that after every comment here is not reasonable.

dusktreader commented 2 years ago

@dusktreader where is this "latest commit" that you mentioned a few times?

Could you please stop squashing your commits while we review the code? This pull request is already insanely long (~1k LOC). Having to over all that after every comment here is not reasonable.

I have not been squashing commits while code is being reviewed. However, I did need to rebase the branch as there was another branch merged into main. Is there another strategy that would make it easier on reviewers? It's hard to make sure things stay up to date with PRs that stay open for a while.

heitorPB commented 2 years ago

On Mon, 01 Nov 2021 10:39:42 -0700 Tucker Beck @.***> wrote:

I have not been squashing commits while code is being reviewed. However, I did need to rebase the branch as there was another branch merged into main. Is there another strategy that would make it easier on reviewers? It's hard to make sure things stay up to date with PRs that stay open for a while.

I think something got squashed while you rebased? Your new commit did not show up on GitHub.

Personally, I avoid squash/rebase while someone is reviewing my PR. This makes it very hard to review specific changes for each comment.