Closed dusktreader closed 2 years ago
@dusktreader where is this "latest commit" that you mentioned a few times?
Could you please stop squashing your commits while we review the code? This pull request is already insanely long (~1k LOC). Having to over all that after every comment here is not reasonable.
@dusktreader where is this "latest commit" that you mentioned a few times?
Could you please stop squashing your commits while we review the code? This pull request is already insanely long (~1k LOC). Having to over all that after every comment here is not reasonable.
I have not been squashing commits while code is being reviewed. However, I did need to rebase the branch as there was another branch merged into main. Is there another strategy that would make it easier on reviewers? It's hard to make sure things stay up to date with PRs that stay open for a while.
On Mon, 01 Nov 2021 10:39:42 -0700 Tucker Beck @.***> wrote:
I have not been squashing commits while code is being reviewed. However, I did need to rebase the branch as there was another branch merged into main. Is there another strategy that would make it easier on reviewers? It's hard to make sure things stay up to date with PRs that stay open for a while.
I think something got squashed while you rebased? Your new commit did not show up on GitHub.
Personally, I avoid squash/rebase while someone is reviewing my PR. This makes it very hard to review specific changes for each comment.