search

omnivore-app / logseq-omnivore

Logseq plugin to fetch articles and highlights from Omnivore
MIT License
284 stars 15 forks source link

WIP: Refactor/file structure #14

Closed satindar closed 2 years ago

satindar commented 2 years ago

Moved things into a src folder and refactored the sync loop. Mainly to get familiar with what the code is doing.

satindar commented 2 years ago

Closing this since it's going to be a rebasing nightmare...and also doesn't work 😄

Will do another after the current milestone.

jacksonh commented 2 years ago

Yeah I was thinking about this one and I think it messes up the expected file structure from Logseq

satindar commented 2 years ago

Yeah I was thinking about this one and I think it messes up the expected file structure from Logseq

Seemed to work okay for me but I might have messed up another mode I haven't used yet. Looked at other plugins to compare (from our Logseq partner Brian 😄 ) and he was also using a /src folder.

Also noticed he used Vite rather than Parcel for bundling but I managed to find the restraint to not not change that haha.

The part I screwed up was trying to refactor the sync loop timer. Tried to make it more ergonomic but it didn't have a cancellation mechanism for ending a loop when settings changed.