search

omnivore-app / logseq-omnivore

Logseq plugin to fetch articles and highlights from Omnivore
MIT License
278 stars 15 forks source link

Setting `headingBlockTitle` to empty generates extra asterisks #161

Open stephanmax opened 7 months ago

stephanmax commented 7 months ago

I am super happy about the headingBlockTitle setting and I immediately set it to empty. Unfortunately, the plugin now includes a lot of unnecessary asterisks in front of block text:

screenshot-20231114-110542Z-selected

sywhb commented 7 months ago

Hey @stephanmax, a new version v1.16.2 is released to address this issue.

Could you please upgrade your plugin, delete the above page in Logseq and resync the article again?

I hope it works!

stephanmax commented 7 months ago

Hey @sywhb, thanks for the swift response!

Unfortunately, I still get the same behavior with 1.16.2.

sywhb commented 7 months ago

Weird. I couldn't replicate it

stephanmax commented 7 months ago

Nevermind—I got it to work! In my first attempt I left the first bullet point of the Omnivore import page in the page which seems to trigger the wrong bulleting. I removed the first bullet/paragraph (not just emptied it) and now it works like a charm. Should have done what you suggested and just deleted the whole page in the first place.

Thanks a mill for your work on this and this wonderful piece of software!

stephanmax commented 6 months ago

Hm, I think I need to re-open this. Newly imported items seem to struggle with the same behavior, see the attached screenshot. Can you replicate?

screenshot-20231210-170410Z-selected

sywhb commented 6 months ago

No, I could not replicate it and the asterisks seem to be generated by Logseq when I call bulkInsert API.

Let me check the code base and see if there is any thing I can do

stephanmax commented 6 months ago

Thanks for looking into this again, really appreciate it. Bear in mind that setting headingBlockTitle to empty and a non-empty import page (setting pageName) trigger that behavior for me.