omnivore-app / logseq-omnivore

Logseq plugin to fetch articles and highlights from Omnivore
MIT License
278 stars 15 forks source link

Put syncAt config field in separate config file #175

Open edshamis opened 5 months ago

edshamis commented 5 months ago

I sync plugin's config files with git and syncAt changes couse conflicts. Consider putting it in a separate file.

jacksonh commented 5 months ago

interesting. I'm not sure if Logseq's APIs will let us store it somewhere else. Will have to look into this.

edshamis commented 5 months ago

Do you think it can be in a property in omnivore page itself? Thus I can see last sync time inside logseq and it's shared with all devices Btw what syncAt is used for? What happens if it's differ at different devices?

On Tue, Jan 23, 2024, 09:58 Jackson Harper @.***> wrote:

interesting. I'm not sure if Logseq's APIs will let us store it somewhere else. Will have to look into this.

— Reply to this email directly, view it on GitHub https://github.com/omnivore-app/logseq-omnivore/issues/175#issuecomment-1905480043, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNR4FX6J73CHA3CMLDFIEDYP5UQ5AVCNFSM6AAAAABCGQLHMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGQ4DAMBUGM . You are receiving this because you authored the thread.Message ID: @.***>

jacksonh commented 5 months ago

syncAt is the last time there was a successful sync, so next time you sync it gets all the changes between those dates. I guess its ok to not be per device since your other devices would eventually sync all the date.