omnivore-app / logseq-omnivore

Logseq plugin to fetch articles and highlights from Omnivore
MIT License
278 stars 15 forks source link

Partial import of highlights and notes, still getting Articles when I have cleared out the entry #191

Open tamouse opened 1 week ago

tamouse commented 1 week ago
  1. I'm missing some of the notes I have written for highlights in an article.
  2. I'm also missing the note for the entire article in the import.
  3. Even though I have cleared out the headingBlockTitle, it still appears on the page.
  4. I'm also getting a repeat of the article template, but an older version under the headingBlockTitle.

I have the following settings:

{
  "generalSettings": "",
  "apiKey": "d4671842-4767-4896-b5b2-bc5f45c35cf3",
  "filter": "import just highlights",
  "customQuery": "",
  "highlightOrder": "the location of highlights in the article",
  "isSinglePage": false,
  "createTemplate": "",
  "createTemplateDesc": "",
  "articleTemplate": "[{{{title}}}]({{{omnivoreUrl}}})\ncollapsed:: true\nsite:: {{#siteName}}[{{{siteName}}}]{{/siteName}}({{{originalUrl}}})\n{{#author}}\nauthor:: {{{author}}}\n{{/author}}\n{{#labels.length}}\ntags:: {{#labels}}[[{{{name}}}]] {{/labels}}\n{{/labels.length}}\ndate-saved:: {{{dateSaved}}}\n{{#datePublished}}\ndate-published:: {{{datePublished}}}\n{{/datePublished}}\nsource:: #Omnivore\n",
  "highlightTemplate": "> {{{text}}} [⤴️]({{{highlightUrl}}}) {{#labels}} #[[{{{name}}}]] {{/labels}}\n\n{{#note.length}}note:: {{{note}}}{{/note.length}}",
  "syncContent": false,
  "advancedSettings": "",
  "frequency": 60,
  "syncAt": "2024-06-23T18:04:56",
  "graph": "PARAshoot",
  "pageName": "Omnivore/{{title}}",
  "headingBlockTitle": "",
  "endpoint": "https://api-prod.omnivore.app/api/graphql",
  "disabled": false,
  "version": "v1.16.5",
  "syncJobId": 9,
  "loading": false
}
jacksonh commented 1 week ago

@tamouse did you try restarting Logseq after updating? I wonder if the plugin could have still been running.

tamouse commented 1 week ago

@jacksonh - I restarted and tried again.

  1. It seems to be pulling the notes over now. 1.b. With the highlight template of
> {{{text}}} [⤴️]({{{highlightUrl}}}) {{#labels}} #[[{{{name}}}]] {{/labels}}

{{#note.length}}note:: {{{note}}}{{/note.length}}

I was expecting the notes to appear below the highlight. Instead they appear above it.

  1. It still doesn't bring over the note for the whole article, just notes attached to highlights.

  2. The headingBlockTitle is not appearing.

  3. I'm not getting the duplicated page properties anymore.

tamouse commented 1 week ago

ok, i am seeing something odd in the logseq page formatting. The notes come after the quote, but the first line, containing note: appears before the quote. Subsequent lines will appear after.

An example:

> Doris Meissner, Commissioner of the U.S Immigration and Naturalization Service between 1993 and 2000, [told](https://www.cnn.com/2016/01/19/politics/donald-trump-deportation-mexico-eisenhower/index.html) CNN that Eisenhower’s program was “lawless; it was arbitrary; it was based on a lot of xenophobia, and it resulted in sizable large-scale violations of people’s rights, including the forced deportation of U.S. citizens.” [⤴️](https://omnivore.app/me/https-open-substack-com-pub-noahberlatsky-p-trump-is-the-heir-of-18fc2986a06#d6cfdd55-8844-44ac-a3af-db92a074fb20) 

note:: lawless and arbitrary - Sounds like Trump.

But there is a bit of this in Obama and Biden as well as prior presidencies of both parties.

This is how the myth of an untouchable president arose, I'm sure, just by us allowing them to do these things as most of us happened to agree they were necessary.

When displayed, it looks like so: OmnivoreTrump Is The Heir of Eisenhower - by Noah Berlatsky 2024-06-24T11-18-55

I am pretty sure it's because of the double colons after note