omnivore-app / logseq-omnivore

Logseq plugin to fetch articles and highlights from Omnivore
MIT License
284 stars 15 forks source link

Highlights can't be imported #35

Closed kimitrois closed 1 year ago

kimitrois commented 2 years ago

Everything is default, but no highlights can be imported. I have no idea if it is a bug or I have just missed some settings. I have tried to make more highlights and add some notes to it, but only the following would be imported into Logseq.

image
jacksonh commented 2 years ago

Hi @kimitrois can you try clearing the syncAt variable from your settings? You can access it by opening the plugin settings, and clicking Edit settings json. Quick demo here: https://www.loom.com/share/acb31e3c7b974819bcb08a7dacd58e3b

kimitrois commented 2 years ago

Hi @kimitrois can you try clearing the syncAt variable from your settings? You can access it by opening the plugin settings, and clicking Edit settings json. Quick demo here: https://www.loom.com/share/acb31e3c7b974819bcb08a7dacd58e3b

Hi @jacksonh , thanks for replying. I followed the demo but it still doesn't work. The result is just the same as the former screenshot.

sywhb commented 2 years ago

Hey @kimitrois i guess you might need to clear the filter in settings. We are making the filter as a selectable config in #37

kimitrois commented 2 years ago

Hey @kimitrois i guess you might need to clear the filter in settings. We are making the filter as a selectable config in #37

Hi @sywhb , I just reinstalled the plugin and cleared the filter but it remains the same. Thanks for helping...

截屏2022-07-12 21 46 38
sywhb commented 2 years ago

@kimitrois Thanks for your patience. I saw the search api being called by the plugin in our logs: searching pages in elastic {"query":{"bool":{"filter":[{"term":{"userId":"ee7424f6-6c95-11ec-a260-2b9341af2833"}},{"range":{"updatedAt":{"gt":"2022-07-12T13:50:30.000Z"}}}],"should":[],"must_not":[]}},"sort":[{"savedAt":{"order":"asc"}}],"from":0,"size":51,"_source":{"excludes":["originalHtml","content"]}}

The updatedAt in the query is 2022-07-12T13:50:30.000Z so only articles updated after this timestamp will be fetched. This might be due to the synced at config not updated properly. May I know if you have any article or highlight saved after 2022-07-12T13:50:30.000Z so we could verify again?

kimitrois commented 2 years ago

Hi @sywhb , after the first failure I did save some new highlights. But I can't know whether it is before or after "2022-07-12T13:50:30.000Z." My last synced at is "synced at": "2022-07-12T13:47:19.539Z" and then I synced again "synced at": "2022-07-12T14:12:57.514Z" (but nothing was fetched)

I save 1 new highlight in an article and then it fetched only that article (without highlight notes), and the time is "synced at": "2022-07-12T14:15:19.560Z"

sywhb commented 2 years ago

Got it, thanks @kimitrois . Yeah the synced at would be updated once the syncing is completed.

For the latest fetched article, is there an arrow besides the title? like this:

Screenshot 2022-07-12 at 10 29 40 PM

If there is one, clicking on that arrow would expand the highlights and annotations.

Screenshot 2022-07-12 at 10 30 01 PM
kimitrois commented 2 years ago

🤦🏻‍♂️ oh shoot, how stupid I am.............It must have worked well since the first click I made...........I see that arrow in my first screenshot....... Thanks and also Sorry for your time , both of you @sywhb @jacksonh

sywhb commented 2 years ago

@kimitrois No worries. It is actually quite useful for us to know and we might be able to improve the UI.

We should probably expand the highlights by default. @jacksonh May I know your opinion on this?