search

omnivore-app / logseq-omnivore

Logseq plugin to fetch articles and highlights from Omnivore
MIT License
279 stars 15 forks source link

Block Reference lost after resync #43

Closed cleanclothes-pi closed 1 year ago

cleanclothes-pi commented 1 year ago

When I create a block reference to the synced article (in Omnivore page) in another page, then re-sync the plug-in, the referenced block is lost. This makes it impossible to reference the highlighted quotes.

I should note that my plug-in setting for "Order of Highlights" is set to "the location of highlighst in the article."

jacksonh commented 1 year ago

Thanks, I guess this is because we remove and re-insert. Maybe we should look into the upsert method, or just only append new nodes.

sywhb commented 1 year ago

48

sywhb commented 1 year ago

Hey @cleanclothes-pi @YU000jp, we released a new version v1.9.0 to address this issue. Please try it and let me know if there should be any further issues.

Thank you! cc: @jacksonh

sywhb commented 1 year ago

Avoid escaping Markdown characters in the title and highlight which caused the fetching failure.

50

cleanclothes-pi commented 1 year ago

@sywhb Thank you so much! As far as my use case goes, it works great now. The reference blocks and quotes are not lost anymore.

I also appreciate that the new comments are appended as new block now instead of replacing the existing one, which means I can add new comments for each highlight directly in Logseq without worrying that it will be overwritten by new sync.

YU000jp commented 1 year ago

When I rewrote the labels and archived, no reference errors occurred.

I can now place web clips on my journal timeline. I get more references to that web clip and reuse them.

you still have another issue, but thank you for your efforts in resolving this issue.