omnivore-app / logseq-omnivore

Logseq plugin to fetch articles and highlights from Omnivore
MIT License
293 stars 16 forks source link

fix: allow users to specify custom template for the article #55

Closed sywhb closed 1 year ago

sywhb commented 1 year ago

@jacksonh I'm adding an option set to allow users to create a custom template for the article and it looks the same by default

jacksonh commented 1 year ago

Checking this one out now!

sywhb commented 1 year ago

Hey @jacksonh, can we merge it?

sywhb commented 1 year ago

Hey @jacksonh, do you think we can merge this and test it?

jacksonh commented 1 year ago

@sywhb yeah, just have to make sure it wont release when we merge!

sywhb commented 1 year ago

@sywhb yeah, just have to make sure it wont release when we merge!

@jacksonh, in this case, I guess we shouldn't merge this now. I may have some misunderstanding. I meant for releasing it not test it. Please let me know when it is good to go

jacksonh commented 1 year ago

Let me try testing it out again locally. Sorry I just saw your updates to the template now. Does this allow for optional handling of items like labels if not null? something like if labels.length > 0 { write(labels) }

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.9.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: