search

omnivore-app / obsidian-omnivore

Obsidian plugin to fetch articles and highlights from Omnivore
MIT License
842 stars 83 forks source link

fix: unescape quote for highlights containing images #113

Closed wuminbin closed 1 year ago

wuminbin commented 1 year ago

when highlighting with images, omnivore might escape url, leading uncorrect preview on markdown. for example, former preview with {{& text}}: former now preview with {{& unescapeText}}: now

jacksonh commented 1 year ago

I wonder if this is an issue on the backend?

wuminbin commented 1 year ago

I wonder if this is an issue on the backend?

May be, but I haven't read the source code yet.

sywhb commented 1 year ago

Hey @wuminbin @jacksonh,

The quote of the highlight was not unescaped in the backend and I have fixed it in the refactored code.

After we deploy it, could you please remove and highlight this image again?

wuminbin commented 1 year ago

@sywhb OK, pls let me know when you deploy.