search

omnivore-app / obsidian-omnivore

Obsidian plugin to fetch articles and highlights from Omnivore
MIT License
813 stars 46 forks source link

Whether the attachment can be downloaded to the local? #13

Open StrollStars opened 1 year ago

StrollStars commented 1 year ago

Whether the attachment of the article can be downloaded and saved to the attachment folder set by Obsidian to prevent the link from becoming invalid.

StrollStars commented 1 year ago

Mainly to prevent the picture from becoming invalid after a long time.

sywhb commented 1 year ago

Hey @StrollStars, sorry for the delay in reply. We actually save the images in our image proxy server so it should not be invalid after some time.

May I know if you have faced such issue?

StrollStars commented 1 year ago

@sywhb Thanks for the reply, I know you cache the pictures on your server, it can be seen from the link of the pictures.In fact, it is difficult for me to access your image server. Considering that it may be used offline, I want to download the image locally.

sywhb commented 1 year ago

Thank you @StrollStars, I see what you mean now.

We have all the images links in the <img> elements of the article content HTML so technically we could parse the HTML and fetch all the images src and download them.

StrollStars commented 1 year ago

@sywhb Thank you for your reply, but could you prioritize https://github.com/omnivore-app/omnivore/issues/1901 and https://github.com/omnivore-app/omnivore/issues/1837? Because that has more impact on synchronization.

MDsza commented 1 year ago

At the moment I use the Obsidian Plugin "Local Images Plus" for this essential feature for a real "read it later app", to get all the relevant attachments offline in my dataset. Unfortunately this plugin does not support iOS / iPadOS at the moment.

StrollStars commented 1 year ago

@MDsza Previously, when I synchronized the entire text, I used the Local Images Plus plugin. However, the recent synchronization template only synchronizes highlighting and notes, so the need to download images to the local storage is not strong.

codeRSH commented 8 months ago

I would like this functionality to be inbuilt in Omnivore. Exporting images as local assests would be useful. Of at least a way to 'highlight' an image so that its link can be synchronised with Obsidian or Logseq. Thanks.