omnivore-app / obsidian-omnivore

Obsidian plugin to fetch articles and highlights from Omnivore
MIT License
726 stars 39 forks source link

Clipping a page with omnivore resulted in obsidian black screen on desktop and android app crashing #163

Open c1505 opened 7 months ago

c1505 commented 7 months ago

Obsidian should not crash based on the content in markdown file and I opened a bug for that side of things. https://forum.obsidian.md/t/obsidian-screen-goes-black-seconds-after-opening/71926/2 . I think this problem could also be prevented by the plugin.

Setup

What happened

Possible changes that could prevent this problem from happening

Additional details

sywhb commented 6 months ago

Hey @c1505 , thanks for the detailed report!

Yeah I think if the file is too big, Obsidian will likely crush. Actually we do have a file size limit which is around 12MB but I guess it's still too big for Obsidian since it has to load it into memory.

I think to have a size limitation settings makes a lot of sense so we could reduce the file size and show some warnings.