Preserve highlight colors in Obsidian

omnivore-app / obsidian-omnivore

Obsidian plugin to fetch articles and highlights from Omnivore

MIT License

726 stars 39 forks source link

Preserve highlight colors in Obsidian #166

Open firmart opened 6 months ago

firmart commented 6 months ago

Currently, Omnivore offers 4 kinds of color to highlight segments of text. However, the highlight color in the converted Obsidian file is always yellow, no matter the chosen color in Omnivore. This might be annoying if each color has been assigned different meanings.

aaachen commented 5 months ago

Encountered same in my workflow, will work on putting out a change

Lorite commented 3 months ago

Hi, have you found a solution? @aaachen I'm using https://github.com/chetachiezikeuzor/Highlightr-Plugin and it would be amazing if they would work together.

aaachen commented 3 months ago

Hi, sorry for the delay, been postponing on this for other stuff

~~Yes the ability to integrate with highlightr plugin is part of my plan for impl, I'll look more into omnivore APIs n get back~~

Update - 3/27: Mapped out how to do it, working on impl

aaachen commented 2 months ago

PR out: https://github.com/omnivore-app/obsidian-omnivore/pull/215

Lorite commented 1 month ago

PR out: https://github.com/omnivore-app/obsidian-omnivore/pull/215

Hi @aaachen, thanks for your amazing work.

I think there's a bug when selecting "Render Highlight Color" and "Use Highlightr for Highlight styling" and following this guide https://blog.omnivore.app/p/guide-for-syncing-highlight-colors. I see the individual highlights in their blocks fine, but for the highlights inside the {{content}} they use double equals (==like this==), not the css classes. Is that intended behavior?