omnivore-app / obsidian-omnivore

Obsidian plugin to fetch articles and highlights from Omnivore
MIT License
726 stars 39 forks source link

add a Option to turn off the new feature:start to sync when plugin is loaded #174

Open calmwaves111 opened 6 months ago

calmwaves111 commented 6 months ago

I hope I can have complete control over the sync In fact, I don't want it to run when starting obsidian because it would slow down my startup speed

mem89de commented 6 months ago

I support this request.

Frequency is set to 0 in my settings, this is explicitly labelled as manual sync. Why would I want it to sync at startup?

blakeNaccarato commented 6 months ago

I like that auto-sync on startup is possible, but agree that it should be configurable, and that sync toasts should be disabled for any auto-sync behaviors.

Toasting button-click/manual sync makes sense, because a user expects the app to react to their intent. Toasting auto-sync (both periodic and startup) may tend to surprise the user, so I don't think that toasts should appear then. I can raise this as a separate issue if it helps the team.

I open Obsidian many times a day to jot things down, and usually it's starting up from scratch, so now I see two Omnisearch toasts obscuring UI every time I open the app. You've gotta tap away the toasts just to see the note header and options, for instance.

I think it's reasonable to default to auto-sync on startup so new users aren't surprised by out-of-sync vaults, as long as it's configurable.

caunus commented 6 months ago

Agreed, suddenly everything is sync. That's not user firendly. Default should be "No sync on startup"! Currently it's a bug not a feature!

DistroByte commented 5 months ago

+1 to this feature request! When using git as source control it prevents pulls from completing successfully because of the conflicting files (local unstaged change to timestamp and upstream "old" timestamp).

Obviously the change can be discarded, but its an extra hurdle to cross.

merqrial commented 5 months ago

+1 to be able to disable this. It updates the last sync timestamp at every obsidian restart. That creates conflicts in git sync. Please can we go ahead with a hacky approach for now? This feature needs to be stopped and enabled with the option to disable it later.

sywhb commented 4 months ago

hey guys, i just added this option in v1.9.4

Screenshot 2024-02-20 at 11 19 35 AM

please let me know if it suits your need

DistroByte commented 4 months ago

Perhaps renaming the heading to "Sync on startup" might be clearer, like how obsidian git has named it? "start" might not be descriptive enough for people

image

sywhb commented 4 months ago

Perhaps renaming the heading to "Sync on startup" might be clearer, like how obsidian git has named it? "start" might not be descriptive enough for people

image

yeah, it is clearer to use startup 👍 i will rename it in the next release. thank you!