Closed aaachen closed 2 months ago
@aaachen Sorry I think the develop
branch is a bit outdated due to some of the latest work pushed to master
branch so I rebased the branch and it created some conflicts 😢
@aaachen Sorry I think the
develop
branch is a bit outdated due to some of the latest work pushed tomaster
branch so I rebased the branch and it created some conflicts 😢
@sywhb Fixed the conflicts in respect to master, lmk if you see any problem
p.s. also removed the "Settings for Omnivore Plugin" and "General" headers according to the guideline here
@aaachen Sorry I think the
develop
branch is a bit outdated due to some of the latest work pushed tomaster
branch so I rebased the branch and it created some conflicts 😢@sywhb Fixed the conflicts in respect to master, lmk if you see any problem
p.s. also removed the "Settings for Omnivore Plugin" and "General" headers according to the guideline here
Looks great to me!
Issue
Issue: https://github.com/omnivore-app/obsidian-omnivore/issues/166
feature: render highlight color in article note improvement: refactor settings tab into its own file
Description
Two options here for highlight css
css-class
style option in Highlightr pluginCaveat
Testing
Screenshots