omnivore-app / obsidian-omnivore

Obsidian plugin to fetch articles and highlights from Omnivore
MIT License
720 stars 39 forks source link

feature: render highlight color in article note #215

Closed aaachen closed 2 months ago

aaachen commented 2 months ago

Issue

Issue: https://github.com/omnivore-app/obsidian-omnivore/issues/166

feature: render highlight color in article note improvement: refactor settings tab into its own file

Description

Two options here for highlight css

  1. directly configure color mapping in Omnivore plugin, comes with rounded highlight but user can choose to customize in their css
  2. delegate color mapping to Highlightr plugin (by setting corresponding highlight css class). Benefit of this option is more highlight style the plugin supports, con is it's another dependency
    • Ensure to pick the css-class style option in Highlightr plugin

Caveat

Testing

Screenshots

settings-1

settings-2

settings-3(highlightr)

article-1

article-2

highlightr-style

settings-overview

sywhb commented 2 months ago

@aaachen Sorry I think the develop branch is a bit outdated due to some of the latest work pushed to master branch so I rebased the branch and it created some conflicts 😢

aaachen commented 2 months ago

@aaachen Sorry I think the develop branch is a bit outdated due to some of the latest work pushed to master branch so I rebased the branch and it created some conflicts 😢

@sywhb Fixed the conflicts in respect to master, lmk if you see any problem

p.s. also removed the "Settings for Omnivore Plugin" and "General" headers according to the guideline here

sywhb commented 2 months ago

@aaachen Sorry I think the develop branch is a bit outdated due to some of the latest work pushed to master branch so I rebased the branch and it created some conflicts 😢

@sywhb Fixed the conflicts in respect to master, lmk if you see any problem

p.s. also removed the "Settings for Omnivore Plugin" and "General" headers according to the guideline here

Looks great to me!