search

omnivore-app / obsidian-omnivore

Obsidian plugin to fetch articles and highlights from Omnivore
MIT License
720 stars 39 forks source link

[BUG] files not synced into single folder when Folder options set #219

Closed ruinshe closed 2 months ago

ruinshe commented 2 months ago

Currently the default sync destination is set as Omnivore/{{{date}}}, but I found Omnivore-{{{date}}} folders created instead of all files begin placed into Omnivore folder.

What I want the synced folder looks like:

.
├── Omnivore
│   ├── 2024-04-08
│   ├── 2024-04-09
│   ├── 2024-04-10
│   ├── 2024-04-14
│   ├── 2024-04-15
│   └── 2024-04-16
...

And actual synced files:

.
├── Omnivore-2024-04-08
├── Omnivore-2024-04-09
├── Omnivore-2024-04-10
├── Omnivore-2024-04-14
├── Omnivore-2024-04-15
├── Omnivore-2024-04-16
...
thatside commented 2 months ago

unfortunately this seems to be caused by https://github.com/omnivore-app/obsidian-omnivore/pull/211 - the fix is replacing forward slash as well as space symbols

I'll try to take a look later but can't guarantee anything as I have no experience with Obsidian plugins

fpehar commented 2 months ago

After the update, I have the same issue: I can't store the notes in a subfolder

Eng4G3 commented 2 months ago

I am having the same or similar issue. Installed the Obsidian plugin yesterday with the file path set to:

03-Resources/Zett

but when it syncs it is actually creating a new folder and populating it: 03-Resources-Zett

sywhb commented 2 months ago

Hey guys, sorry for the mess.

I just released a new version 1.10.1 to fix this bug. Credits to @Tesselay for the speedy response!

cc: @fpehar @ruinshe @thatside @Eng4G3 @StrollStars

Tesselay commented 2 months ago

Glad I could help!

StrollStars commented 2 months ago

@sywhb Thank you very much!

ruinshe commented 2 months ago

Thanks! I upgraded and verified the issue is gone in latest version of Obsidian plugin, closing this issue.