omnivore-app / omnivore

Omnivore is a complete, open source read-it-later solution for people who like reading.
https://omnivore.app
GNU Affero General Public License v3.0
13.6k stars 879 forks source link

[Enhancement] Define table borders for better readability #1488

Closed Bad3r closed 1 year ago

Bad3r commented 1 year ago

Currently, tables are missing internal borders:

For better readability, define table borders; for example:

Before defining table border:

After defining table border:

I recently fixed this same issue in Logseq using the following code snippet:

/* Define Table Borders */
table.mytable {
    border-collapse: collapse;
    border-spacing: 0;
  }
  table.mytable td {
    text-align: center;
    vertical-align: middle;
    border-color: #D8DEE9;
    border-style: solid;
    border-width: 1px;
  }
  table.mytable th {
    text-align: center;
    vertical-align: middle;
    border-color: #D8DEE9;
    border-style: solid;
    border-width: 1px;
  }

The original code is from: https://logseq.abosen.top/#/page/logseq%E4%B8%AD%E5%A4%8D%E6%9D%82%E8%A1%A8%E6%A0%BC%E7%9A%84%E5%AE%9E%E7%8E%B0

Bad3r commented 1 year ago

While creating this feature request, I noticed a weird behaviour that could be a bug or the intended behaviour

Use this page as an example: https://github.com/gh0stzk/dotfiles

the table in the readme is render as:

After saving the page to Omnivore, notice that only the first row is centered. All other rows are left aligned:

jacksonh commented 1 year ago

Nice, thanks. Going to see if we can just drop this CSS in.

Bad3r commented 1 year ago

@jacksonh I assume it wasn't that simple?