search

omnivore-app / omnivore

Omnivore is a complete, open source read-it-later solution for people who like reading.
https://omnivore.app
GNU Affero General Public License v3.0
13.61k stars 880 forks source link

adapt size to smaller windows #1950

Closed Bad3r closed 1 year ago

Bad3r commented 1 year ago

I enjoy using Omnivore on my 2k monitor, positioning it in the corner, and running it in a browser window with dimensions 1266 x 690. However, at this specific size, Omnivore does not resize properly, causing a few UI issues:

Screenshot: 2023-03-26_13-49

Compared to Raindrop, which has a similar UI at the same size: 2023-03-26_13-51

jacksonh commented 1 year ago

Thanks, this appears to be right inbetween some breakpoint sizes for us. Trying to make the menu a bit smaller as the screen shrinks to give the grid enough room

Bad3r commented 1 year ago

Thank you for considering fixing the issue. I am unsure if I am the only one that uses Omnivore at 1/4 the screen size, but a 2k monitor size is common.

jacksonh commented 1 year ago

@Bad3r no i think its quite common, i was using my Windows laptop yesterday for some testing and it happened to be exactly the same size. I'm playing with a few options, both breaking the cards down to less columns earlier, and shrinking the left menu a tiny bit.

In the meantime, the list view seems to work a lot better.

Bad3r commented 1 year ago

I have noticed that the UI now fits as expected, thank you! Feel free to close the issue :D

Bad3r commented 1 year ago

on a second look.. I see now that there is a horizontal scrollbar image

Bad3r commented 1 year ago

could the gaps on the right, left, or between the cards be slightly shrunk to make everything fit better?

jacksonh commented 1 year ago

Yeah, there are a few issues here. I think the main one is on windows we shouldn't be showing that scrollbar at the bottom. It would be nice if the card gap was a little more flexible, we do constrain the cards to a container so we can keep them centred, but it seems like there is more space than there should be on the left, and ideally the gab could grow instead of the margin spacing.

markpinero commented 1 year ago

Yeah, there are a few issues here. I think the main one is on windows we shouldn't be showing that scrollbar at the bottom. It would be nice if the card gap was a little more flexible, we do constrain the cards to a container so we can keep them centred, but it seems like there is more space than there should be on the left, and ideally the gab could grow instead of the margin spacing.

I've run into this issue elsewhere so I can make a PR with updates when I can.