search

omnivore-app / omnivore

Omnivore is a complete, open source read-it-later solution for people who like reading.
https://omnivore.app
GNU Affero General Public License v3.0
13.61k stars 880 forks source link

Suggest to support modifying the source link #1996

Closed StrollStars closed 11 months ago

StrollStars commented 1 year ago

In case the original link becomes invalid, it is recommended to modify the original link.

jacksonh commented 1 year ago

Hey, one thing to note is we do ingest and save the original content, its just not exposed anywhere in the UI.

This is a good idea, really every attribute should be editable. One issue is if there are conflicts, as we do require URLs to be unique internally.

jacksonh commented 1 year ago

What I am thinking is we might want an API that exposes all attributes, and then we can use a basic table/form editor for this page as its a more advanced tool.

StrollStars commented 1 year ago

really every attribute should be editable. One issue is if there are conflicts, as we do require URLs to be unique internally.

@jacksonh I think so too, but why is there a conflict?

jacksonh commented 1 year ago

@StrollStars oh if you changed the URL to one that you also have already saved. So you have one page with the URL omnivore.app/xyz and then you try to change the URL to omnivore.app/xyz we would have to fail the operation because you can't have two pages with the same URL in our database.

StrollStars commented 1 year ago

@jacksonh I think there is no problem, when repeated, save failed and give a prompt.

StrollStars commented 11 months ago

I feel this suggestion is unreasonable, so close it.