omnivore-app / omnivore

Omnivore is a complete, open source read-it-later solution for people who like reading.
https://omnivore.app
GNU Affero General Public License v3.0
13.92k stars 984 forks source link

Search does not look into manually added note #2129

Open jakemkc opened 1 year ago

jakemkc commented 1 year ago

Hi all,

Thanks for creating the great read-it-later app Omnivore for the community. I use it almost daily and it's becoming an important part of my routine.

I usually create notes for the article saved. However, I discovered that the search function won't look for text in my manually typed notes.

I wonder is it a design feature not to search into notes but only text from the original page?

Best, Jake

jacksonh commented 1 year ago

Thanks @jakemkc yeah we definitely need this. Perhaps as a starting point a scope like note:<the text>.

it was definitely not intentional, just search was implemented before we really had notes.

rochakagrawal commented 1 year ago

just to add - i would love this feature as well

jacksonh commented 1 year ago

Linking these two https://github.com/omnivore-app/omnivore/issues/1802