omnivore-app / omnivore

Omnivore is a complete, open source read-it-later solution for people who like reading.
https://omnivore.app
GNU Affero General Public License v3.0
13.6k stars 878 forks source link

🐛 BUG: Obsidian Omnivore plugin does not create notes #2468

Open sschneider-ihre-pvs opened 1 year ago

sschneider-ihre-pvs commented 1 year ago

When I try to sync the tutorial articles I get

image

but nothing is created in obsidian. I have checked sync all articles. and i have an api key

sschneider-ihre-pvs commented 1 year ago

It seems that, if there has not been any changes, metadata or content they will not sync

jacksonh commented 1 year ago

@sschneider-ihre-pvs do you mean you add a note to an article that has already been synced, and then attempt to re-sync and the note is not pulled in?

sschneider-ihre-pvs commented 1 year ago

more like, a brand new account where only the tutorials are there and I cannot sync that, or if I add an article with the browser extension without changing anything it also seems to be ignored, as soon as I touch something the obsidian plugin is able to pull them in.

aaachen commented 10 months ago

I tested this issue and noticed the same. When I looked into further in code, the issue reported is a result of the command behavior and default filter setting. There's no actual bug technically in Omnivore itself

Repro

The plugin's two commands:

Filter: The condition to filter the result. The default is "import just Highlights"

Plugin Behavior: The articles returned is the result pulled by Sync (or Resync), filtered down by the Filter.

This is my following sequence (and likely what OP did):

  1. Run Sync (user wanting to pull all my articles)
    • Because it's a new account, nothing is highlighted, so no articles are returned
  2. Run Sync/Resync again, same thing as 1.
  3. Noticed the Filter in the setting, change to "import All my Articles"
  4. Run Sync again
    • ("Bug") Because the behavior of Sync, only articles with delta are being pulled in, despite the filter being changed.

If I do "Resync" after step 3 or 4, the plugin works correctly in pulling everything I need

aaachen commented 10 months ago

Admittedly this would seem like a bug for the User's UX without any code insight, maybe we can

sywhb commented 10 months ago

yeah, this is affecting more users and thanks guys for the clear description.

agree with @aaachen's both idea and i will work on them.

besides that, do you guys think we should default sync all items instead of just highlights? cc @jacksonh @sschneider-ihre-pvs

aaachen commented 10 months ago

Here's PR: https://github.com/omnivore-app/obsidian-omnivore/pull/168

@sywhb I can help take this if you haven't got a chance yet to work on

johnnynalley commented 9 months ago

Edit: The plugin settings are weird. Sometimes, changing settings fixes it, sometimes, it breaks it. I've gotten it to work for now, but I'm not touching my setting anymore.

I believe I am experiencing this same issues. I've synced, resynced, and nothing populated the Omnivore folder. All of my settings are default, including the filter, so the full article should be saved. I added a few highlights and notes and those did not move over either. I have removed the plugin, created a new API key, and reinstalled the plugin using my new API key, and same result. I am on iOS 17.3.