omnivore-app / omnivore

Omnivore is a complete, open source read-it-later solution for people who like reading.
https://omnivore.app
GNU Affero General Public License v3.0
13.92k stars 983 forks source link

Extension spinner hangs with no error message in Brave Browser when using 'site-access' = 'on-click' #4420

Open ngelx opened 1 month ago

ngelx commented 1 month ago

Description

When using the Omnivore browser extension in Brave, the spinner continues spinning indefinitely without any error message. This appears to be related to an authentication issue.

Steps to Reproduce:

  1. In Brave browser, set the extension's 'site-access' setting to 'on-click'.
  2. Try using the extension.
  3. Notice that the spinner hangs without completing the action.

Expected Behavior

The extension should authenticate and load as expected, or provide an error message if something goes wrong.

Workaround

Setting the 'site-access' to 'on-all-sites' allows the extension to work as expected.

Versions

Brave version: 1.70.126 Omnivore Extension version: 2.10.0

Additional Information

It seems this issue occurs due to how the extension handles authentication when limited to 'on-click' site access.