search

omnivore-app / omnivore

Omnivore is a complete, open source read-it-later solution for people who like reading.
https://omnivore.app
GNU Affero General Public License v3.0
13.92k stars 984 forks source link

fix: resolve local redis and docker build errors #4437

Open rbarbazz opened 4 weeks ago

rbarbazz commented 4 weeks ago

I encountered a couple of issues when running the app locally, which this PR addresses:

  1. Fix for MacBook M1 build issue (commit: 81dbccacca90818f9377e26609afb7e081179d5d, closes #3315):

    • On a MacBook Air M1 8GB, I ran into the issue described in #3315. This commit resolves it.
    • The change mirrors an existing step in the runner stage, so it should not affect the current build pipeline.

  2. Fix for Redis connection error (commit: f7ae2a44c7793774debe8cff1f676020de83308f):

    • While running docker compose up api content-fetch, I encountered this error: 
      omnivore-api            | [ioredis] Unhandled error event: Error: connect ENOENT %27redis://redis:6379%27
omnivore-api            |     at PipeConnectWrap.afterConnect [as oncomplete] (node:net:1494:16)
    • Removing the single quotes around the default REDIS_URL fixed the issue. Edit: I just noticed there's already another PR that implements this fix https://github.com/omnivore-app/omnivore/pull/4378, happy to revert.
vercel[bot] commented 4 weeks ago

@rbarbazz is attempting to deploy a commit to the omnivore Team on Vercel.

A member of the Team first needs to authorize it.