search

omoindrot / tensorflow-triplet-loss

Implementation of triplet loss in TensorFlow
https://omoindrot.github.io/triplet-loss
MIT License
1.12k stars 283 forks source link

Performance issue in /model/tests (by P3) #61

Open DLPerf opened 3 years ago

DLPerf commented 3 years ago

Hello! I've found a performance issue in /model/tests/test_triplet_loss.py: with tf.Session() as sess(here) is repeatedly called in the loop for squared in [True, False](here).

tf.Session being defined repeatedly could lead to incremental overhead. If you define tf.Session out of the loop and pass tf.Session as a parameter to the loop, your program would be much more efficient. Here is the Stack Overflow post to support it.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

DLPerf commented 3 years ago

Hello, I'm looking forward to your reply~