omoponfhir / omoponfhir-omopv5-stu3-conceptmapping-server

Concept Mapping Server
Apache License 2.0
0 stars 2 forks source link

ConceptMap in CapabilityStatement isn't valid #5

Open mstrotta opened 4 years ago

mstrotta commented 4 years ago

We're using GT-FHIR2 for OMOPv5 in CS6440 at https://apps.hdap.gatech.edu/gt-fhir/fhir/metadata. The resource at .rest[0].resource[0] in the conformance statement looks like:

{ "type": "ConceptMap",
 "profile": {
 "reference": "http://hl7.org/fhir/StructureDefinition/ConceptMap"
 } } 

This doesn't appear to be conformant. For example, it doesn't contain an interaction.code. I'm using fhirclient.py to connect, and the client assumes that all resources rest have an interaction.

myungchoi commented 4 years ago

Hi,

That is because the resource ConceptMap in omoponfhir server current does not support any resource level interactions. We use this resource to support other operation, translation between code systems. And, the operation needs to go through ConceptMap resource. In the future, we would provide the ConceptMap from concept table of OMOP. But, currently, we do not have it.

The spec says that if we have a resource, we need to have the interaction with at least one interaction. But, we don’t have any implemented. So, it has no interaction. Is it hard for you to check if the key exists?

Thanks, Myung

On Mar 21, 2020, at 3:02 PM, mstrotta notifications@github.com wrote:

We're using GT-FHIR2 for OMOPv5 in CS6440 at https://apps.hdap.gatech.edu/gt-fhir/fhir/metadata https://apps.hdap.gatech.edu/gt-fhir/fhir/metadata. The resource at .rest[0].resource[0] in the conformance statement looks like:

{ "type": "ConceptMap", "profile": { "reference": "http://hl7.org/fhir/StructureDefinition/ConceptMap" } } This doesn't appear to be conformant. For example, it doesn't contain an interaction.code. I'm using fhirclient.py to connect, and the client assumes that all resources rest have an interaction.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/omoponfhir/omoponfhir-omopv5-stu3-conceptmapping-server/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQRHRTEKDVSFUSOZ7HGDP3RIUFMDANCNFSM4LRAKVGA.

myungchoi commented 4 years ago

Actually, I see your issue. You are using smart on FHIR python library.

I will see if I can fix it.

Sent from my iPhone

On Mar 21, 2020, at 3:02 PM, mstrotta notifications@github.com wrote:

 We're using GT-FHIR2 for OMOPv5 in CS6440 at https://apps.hdap.gatech.edu/gt-fhir/fhir/metadata. The resource at .rest[0].resource[0] in the conformance statement looks like:

{ "type": "ConceptMap", "profile": { "reference": "http://hl7.org/fhir/StructureDefinition/ConceptMap" } } This doesn't appear to be conformant. For example, it doesn't contain an interaction.code. I'm using fhirclient.py to connect, and the client assumes that all resources rest have an interaction.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

mstrotta commented 4 years ago

Yes. The quick way to prevent an error in the Python library was to change the CapabilityStatementRestResource domain model so that interaction is not required. That worked for me locally, but I thought it would be good to raise the issue.

Best, Mike

On Sun, Mar 22, 2020 at 2:38 AM Myung Choi notifications@github.com wrote:

Actually, I see your issue. You are using smart on FHIR python library.

I will see if I can fix it.

Sent from my iPhone

On Mar 21, 2020, at 3:02 PM, mstrotta notifications@github.com wrote:

 We're using GT-FHIR2 for OMOPv5 in CS6440 at https://apps.hdap.gatech.edu/gt-fhir/fhir/metadata. The resource at .rest[0].resource[0] in the conformance statement looks like:

{ "type": "ConceptMap", "profile": { "reference": "http://hl7.org/fhir/StructureDefinition/ConceptMap" } } This doesn't appear to be conformant. For example, it doesn't contain an interaction.code. I'm using fhirclient.py to connect, and the client assumes that all resources rest have an interaction.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/omoponfhir/omoponfhir-omopv5-stu3-conceptmapping-server/issues/5#issuecomment-602155090, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKI4W5VY7P4QXGXWEKJRDDRIWW5RANCNFSM4LRAKVGA .

myungchoi commented 4 years ago

The missing interaction is fixed. You should be able to use smart on FHIR python library without changing it.

Please note that the ConceptMap will always return null.

Thanks,

Sent from my iPhone

On Mar 22, 2020, at 9:46 AM, mstrotta notifications@github.com wrote:

 Yes. The quick way to prevent an error in the Python library was to change the CapabilityStatementRestResource domain model so that interaction is not required. That worked for me locally, but I thought it would be good to raise the issue.

Best, Mike

On Sun, Mar 22, 2020 at 2:38 AM Myung Choi notifications@github.com wrote:

Actually, I see your issue. You are using smart on FHIR python library.

I will see if I can fix it.

Sent from my iPhone

On Mar 21, 2020, at 3:02 PM, mstrotta notifications@github.com wrote:

 We're using GT-FHIR2 for OMOPv5 in CS6440 at https://apps.hdap.gatech.edu/gt-fhir/fhir/metadata. The resource at .rest[0].resource[0] in the conformance statement looks like:

{ "type": "ConceptMap", "profile": { "reference": "http://hl7.org/fhir/StructureDefinition/ConceptMap" } } This doesn't appear to be conformant. For example, it doesn't contain an interaction.code. I'm using fhirclient.py to connect, and the client assumes that all resources rest have an interaction.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/omoponfhir/omoponfhir-omopv5-stu3-conceptmapping-server/issues/5#issuecomment-602155090, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKI4W5VY7P4QXGXWEKJRDDRIWW5RANCNFSM4LRAKVGA .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.