Open WangWeiLin-MV opened 3 months ago
Yes, agree. It will be easier after this PR. https://github.com/ompl/omplapp/pull/13
If omplapp
called find_package(ompl CONFIG)
before it brought it in as a submodule, would that fix it for you?
If
omplapp
calledfind_package(ompl CONFIG)
before it brought it in as a submodule, would that fix it for you?
Yes, the duplicate build could be avoided in that way.
@mamoll Can you move this to omplapp? This issue is specific to omplapp
@Ryanf55 done.
Hi,
I am a member of the VCPKG project. I found that
omplapp
repeatedly builds "ompl" from the submodule instead of depends on the built libraries https://github.com/microsoft/vcpkg/pull/40151.I see that ompl/ompl#1066 ompl/ompl#1067 adds the CMake targets
ompl::ompl
, which allow for convenienttarget_link_libraries(main PRIVATE ompl::ompl)
, but omplapp not uses it, and it bypassesompl/CMakeLists.txt
to compile its components like this omplapp/CMakeLists.txt#L252-L257:And there are many different parts between the two files omplapp/CMakeLists.txt and ompl/CMakeLists.txt. Splitting the two projects need a lot of changes.
I would like to ask if it is possible to modify omplapp to be a project that depends on ompl, rather than an ompl variant that shares a lot of code? This is very helpful to us, and I think this will also make it easier to develop
omplapp
.If you have any questions please let me know. Thanks in advance.