search

omridevk / ng-keyboard-shortcuts

Dead Simple Keyboard Shortcuts Management for Angular
https://ng-keyboard-shortcuts.vercel.app/
147 stars 34 forks source link

Shortcut modal overflows and does not scroll #24

Closed jnfaerch closed 5 years ago

jnfaerch commented 5 years ago

Describe the bug The modal does not scroll when higher than vh (and is not responsive)

To Reproduce Adjust the vh to be less than the modal height or increase the number of shortcuts to overflow the vh

Expected behavior The modal should be visible in its entirety in order for the user to see all shortcuts

Screenshots ng-keyboard-shortcuts

Desktop

Smartphone

Additional context I am not able to find where to override the styling of the modal in order to fix it that way. From Chrome console on scroll [Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive. See <URL> <URL> === https://www.chromestatus.com/features/6662647093133312

omridevk commented 5 years ago

@jnfaerch Yes I am currently aware of (prevent default inside passive event warning) Will be fixed in the new release. I will try to provide a workaround later today or tomorrow. Thanks for reporting the issue, sorry for the inconvenience.

omridevk commented 5 years ago

a version should be released either this weekend, or by mid next week. Thanks for the patience.

omridevk commented 5 years ago

fixed in this version: https://github.com/omridevk/ng-keyboard-shortcuts/releases/tag/7.0.11 Let me know if the issue persist. Thanks for the reporting the bug.