ng-keyboard-shortcuts imports from rxjs/internals

omridevk / ng-keyboard-shortcuts

Dead Simple Keyboard Shortcuts Management for Angular

https://ng-keyboard-shortcuts.vercel.app/

147 stars 34 forks source link

Closed Goobles closed 4 years ago

Goobles commented 5 years ago

Describe the bug This module imports from rxjs/internals https://github.com/omridevk/ng-keyboard-shortcuts/blob/9bbd6a8b38359f8c21697bd2da00893bb326aec4/projects/ng-keyboard-shortcuts/src/lib/ng-keyboard-shortcuts-help.component.ts#L20

This is not recommended and will increase the bundle size by including all of rxjs

omridevk commented 5 years ago

Thank you, will be fixed in the next release, hopefully i will get to it soon as angular 9 is released. Thanks again for the nice catch.

omridevk commented 5 years ago

@Goobles Of course, feel free to create a PR if you wish, I will try to get it to as soon as possible.

omridevk commented 4 years ago

done.

omridevk commented 4 years ago