search

omridevk / ng-keyboard-shortcuts

Dead Simple Keyboard Shortcuts Management for Angular
https://ng-keyboard-shortcuts.vercel.app/
147 stars 34 forks source link

Compatibility with angular 9 #52

Closed yarres closed 4 years ago

yarres commented 4 years ago

I tested to update an application to angular 9 via ng update @angular/cli @angular/core, turns out it's impossible. Here's the error message : Package "ng-keyboard-shortcuts" has an incompatible peer dependency to "zone.js" (requires "^0.9.1", would install "0.10.2").

I have no idea if the compatibility to angular 9 of your package is trivial or complex but that feature would be really useful very soon.

Thanks in advance, and thanks for your work on this package.

omridevk commented 4 years ago

I have a task to support angular 9, hopefully i will release a version this weekend, sorry for the inconvenience. And thank you very much for reporting the issue. Will update this ticket once a fix is released.

jnfaerch commented 4 years ago

Just add --force to update. This library works fine in Angular 9

yarres commented 4 years ago

Thanks for your very prompt answer, it's appreciated.

omridevk commented 4 years ago

yes, the issue is just with the dependencies, I am will add depdenpot soon so these sort of problems will go away. thanks @jnfaerch for the good advise!

omridevk commented 4 years ago

the library itself does not use any of angular features with breaking changes in angular 9.

omridevk commented 4 years ago

fixed