added support for controlling audio devices on linux

Pieterv24 commented 3 years ago

I've added support to control PA sinks directly with deej instead of only controlling individual applications

Pieterv24 commented 3 years ago

I've updated the documentation. As for whether it'd be possible for a conflict of device and process names to occur, technically I'd say yes although it is highly unlikely since device names are usually very unique, so someone would have to explicitly make a binary that has the same name as a output device.

There are a few courses of action that can be taken.

Just leave it as is, this will most likely not cause any issues.
Add something to check whether a session with the given key is already in the session list, if so, don't add a new one or add something like (1) to the end
Use the Sink name instead of the Sink Description, this is more unique, but has the downside of being less human readable and less intuitive in use. for example Built-in Audio Digital Stereo (IEC958) would become alsa_output.pci-0000_00_1f.3.iec958-stereo which can only be retrieved by running pactl list sinks instead of being able to use the name that is used in the PulseAudio GUI.

I've tested this on Arch Linux, PulsaAudio 13.99.3 (Latest)

fkreiner commented 3 years ago

Is this still a Thing?

omriharel commented 3 years ago

@fkreiner it is, but I'm going to need to find time to bring it up to speed w/ my requirements. I keep putting it off, but I'll prioritize it higher now that there's more interest.

fkreiner commented 3 years ago

No pressure. Just wanted to see if pulse will be implemented some day

omriharel commented 3 years ago

Just to clarify, pulse is already supported and you can build and use deej on Linux right now (check out the main readme for instructions).

This PR further adds to that with device targeting capabilities, which are currently missing on Linux (being able to tell deej to control a specific audio device like speakers or headphones, as opposed to just apps/master).

On Thu, Mar 25, 2021, 02:42 Florian Kreiner @.***> wrote:

No pressure. Just wanted to see if pulse will be implemented some day

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/omriharel/deej/pull/18#issuecomment-806275260, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOSGJ4BUYBFQRMXX2ECB5DTFKBGZANCNFSM4TH2QQWA .

Pieterv24 commented 3 years ago

Seems like I accidentally closed the PR by trying to move my branches

oerkel47 commented 2 years ago

This would be a nice addition! :-)

omriharel / deej

added support for controlling audio devices on linux #18