session_finder_linux: fall back to application.name if application.process.binary fails

omriharel / deej

Set app volumes with real sliders! deej is an Arduino & Go project to let you build your own hardware mixer for Windows and Linux

https://deej.rocks

MIT License

4.71k stars 433 forks source link

session_finder_linux: fall back to application.name if application.process.binary fails #77

Closed ajs124 closed 5 months ago

ajs124 commented 5 months ago

Closes https://github.com/omriharel/deej/issues/76

ajs124 commented 5 months ago

Ah, just saw https://github.com/omriharel/deej/blob/master/docs/CONTRIBUTING.md#pull-requests-and-alternate-forks

I hope you might still consider this change, since it's quite minimal, fixes a reported bug and doesn't change existing behavior.

If not… well, feel free to take this commit @riegojerey

omriharel commented 5 months ago

Hi @ajs124, thank you for your interest in contributing!

I've looked at the change and understand how it can help in this instance, but I'm currently leaning towards not including it unless I can fully understand its wider implications and possibly design for them in a way that doesn't allow potential conflicts to occur when targeting other processes. I would also encourage @riegojerey to take the change from your fork in the meantime.