search

omriharel / deej

Set app volumes with real sliders! deej is an Arduino & Go project to let you build your own hardware mixer for Windows and Linux
https://deej.rocks
MIT License
4.71k stars 433 forks source link

Added support for logarithmic potentiometers #90

Closed CodingFactoryT closed 5 months ago

CodingFactoryT commented 5 months ago

This pull request adds the ability to also use logarithmic potentiometers whose values are mapped to linear values.

omriharel commented 5 months ago

Hey there @CodingFactoryT, thank you for your interest in contributing to deej.

As per the project's contribution guidelines, I'm currently not accepting PR submissions for deej's main fork. That being said, I encourage you to continue working on these changes to your heart's content in your own fork of the project.

In the context of this specific change - the workaround in this PR isn't a true solution as it's unable to restore data lost to the physical properties of the potentiometer (which originate in its taper). It provides an approximation, but doesn't provide any real improvement to the feel of using a pot of this type. As I mentioned in #88, users shouldn't need to feel like they need to use this workaround - logarithmic pots will probably feel just fine for most people.