omrikiei / aws_logging_handlers

AWS integration for python logging handlers(S3, Kinesis)
https://omrikiei.github.io/aws_logging_handlers/
MIT License
71 stars 27 forks source link

README is wrong! #10

Closed topcoderkz closed 5 years ago

topcoderkz commented 5 years ago

Please change from aws_logging_handlers import S3Handler --> from aws_logging_handlers.S3 import S3Handler

from aws_logging_handlers import KinesisHandler --> from aws_logging_handlers.Kinesis import KinesisHandler

Also, even though it uploads logs to S3 bucket, the whole program (in readme) hangs!

omrikiei commented 5 years ago

Hi, README is fixed, I'll try to take a look at the README code that hangs sometime soon. Thank you for bringing it to my attention - I indeed did not update the readme code following the refactoring I've done