omrikiei / ktunnel

A cli that exposes your local resources to kubernetes
GNU General Public License v3.0
913 stars 71 forks source link

Fix race condition in deployment ready state detection #104

Closed lionelnicolas closed 1 year ago

lionelnicolas commented 1 year ago

When a deployment is updated (using --reuse), and if waitForReady() is invoked before k8s actually started to schedule pods, then it will return immediately and eventually fail with:

failed parsing session uuid from stream, skipping  error="invalid UUID length: 0" session=

Using watchForReady() instead ensure that the deployment actually reach a stable state.