search

omrikiei / ktunnel

A cli that exposes your local resources to kubernetes
GNU General Public License v3.0
928 stars 71 forks source link

Add resource request for injected ktunnel server sidecar #19

Closed jonastim closed 4 years ago

jonastim commented 4 years ago

Thanks for the great tool, @omrikiei!

I ran into a small issue on my Kubernetes cluster. The injected sidecar doesn't specify any resource request (resources: {} in the deployment yaml) which the cluster doesn't allow. My workaround is to manually edit the yaml and add CPU and memory limits and requests to unblock the deployment. Could you add a reasonable default to make that step unnecessary?

omrikiei commented 4 years ago

Hey @jonastim, i'll try to take a look over the weekend, thanks you

omrikiei commented 4 years ago

releasing a version that requests 500m for the injected pod, is your cluster enforcing both requests and limits and both cpu and memory?

jonastim commented 4 years ago

Great! Yes, in the Replica Set event log the error is Error creating: pods <pod name> is forbidden: failed quota: cpu-mem-hard-limits: must specify cpu, memory

omrikiei commented 4 years ago

👍 so I'll need to refine this change, will release a newer minor version in the tonight

omrikiei commented 4 years ago

should be working in release v1.2.5, could you please verify?

jonastim commented 4 years ago

Works great 👍 I couldn't install through brew and grabbed the binary. It says version 1.2.4 but I assume it was just forgotten to bump somewhere.

❯ ~/Downloads/ktunnel_1.2.5_Darwin_x86_64/ktunnel --version
ktunnel version 1.2.4
omrikiei commented 4 years ago

Yes, will take care of this soon, closing.