Closed jaredallard closed 3 years ago
Tested this out and it seems like there is issues with concurrent connections, going to need to fix this :sob:
Tested this out and it seems like there is issues with concurrent connections, going to need to fix this š
Could you elaborate? what are you seeing?
@omrikiei It looks like when two connections, or more, are made at once something is getting deadlocked.
I moved my project to ssh tunneling to remove this for now, and I'm pretty sure I actually fixed this but deleted the code on accident. I need to re-do this sometime soon. It might be a bit though, now that I stopped using this.
Maybe it makes sense to have this project also be using ssh tunneling?
Ill see if I'm able to reproduce and troubleshoot it
What this PR does: This PR fixes the issues found in https://github.com/omrikiei/ktunnel/issues/24, and some struggles I ran into when trying to use this as a library with my own project. The main highlights are:
context
for cancellation in both the client and server.ioutil.Discard
as the out.What's left?
This is what is keeping this in draft currently:
cmd/
to support the new functional args interface, and pass in a logger.Notes for my reviewer: I'm happy to split this into chunks, if that's wanted!