search

omrikiei / ktunnel

A cli that exposes your local resources to kubernetes
GNU General Public License v3.0
925 stars 71 forks source link

Add flag to make ejecting the sidecar optional #51

Closed sjones512 closed 3 years ago

sjones512 commented 3 years ago

Thought it would be redundant to create an issue and a PR, so just created the PR and thought it could be discussed here. Let me know if you would prefer a different flow.

We have a use case where we would like to keep the sidecar in the pod to minimize redeployments because any changes made in the pod are lost when it is re-deployed.

A better place for something like this may be a ktunnel client deployment subcommand, but implementing it this way required far fewer changes.

Not sure if this is a common enough use-case to warrant merging, but thought it couldn't hurt to share.

omrikiei commented 3 years ago

Hey @sjones512 - I'll test it in the next couple of days. I have an alternative purposed solution that might work, you can include ktunnel in your deployment manifest and then use the a port-forward to the pod(28688) and use ktunnel client.

sjones512 commented 3 years ago

We did figure out that we can manually run the port forward and the ktunnel client command, which we can go back to if it isn't a feature worth integrating.

Just thought it would be easier/less steps for end users to not have to run multiple commands.

Thanks for looking!

On Fri, May 14, 2021, 4:36 PM Omri Eival @.***> wrote:

Hey @sjones512 https://github.com/sjones512 - I'll test it in the next couple of days. I have an alternative purposed solution that might work, you can include ktunnel in your deployment manifest and then use the a port-forward to the pod(28688) and use ktunnel client.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/omrikiei/ktunnel/pull/51#issuecomment-841551663, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOBDLQ7ZI6T6Y2FDOZ6J7TTNWXY5ANCNFSM442VHOZA .

omrikiei commented 3 years ago

@sjones512 it's a good suggestion