unknown shorthand flag: 'r' in -r

stb1337 commented 3 years ago

On your README it says:

ktunnel expose myapp 80:8000 -r #deployment & service will be reused if exists or they will be created

but sadly there's no flag on ktunnel version 1.4.0

ktunnel expose -n cluster-base some-service-svc 80:80 -r
Error: unknown shorthand flag: 'r' in -r
Usage:
  ktunnel expose [flags] SERVICE_NAME [ports]

Examples:

# Expose a local application running on port 8000 via http
ktunnel expose kewlapp 80:8000

# Expose a local redis server
ktunnel expose redis 6379

Flags:
  -c, --ca-file string                TLS cert auth file
  -h, --help                          help for expose
  -n, --namespace string              Namespace (default "default")
  -s, --scheme string                 Connection scheme (default "tcp")
  -o, --server-host-override string   Server name use to verify the hostname returned by the TLS handshake
  -i, --server-image string           Ktunnel server image to use (default "quay.io/omrikiei/ktunnel:v1.4.0")

Global Flags:
  -p, --port int   The port to use to establish the tunnel (default 28688)
  -t, --tls        Connection uses tls if true, else plain TCP
  -v, --verbose    verbose mode

cblims commented 3 years ago

Seems like brew is not updated for version 1.4.3. I downloaded from GitHub releases and this version has reuse enabled...

omrikiei commented 3 years ago

on it

omrikiei commented 3 years ago

@cblims thank you for bringing this to my attention - could you please recheck now?

cblims commented 3 years ago

Works! now updated with brew! Thx! Have you considered Chocolately for Windows binary distribution?

stb1337 commented 3 years ago

Update was successful via brew. Thx.

`brew install omrikiei/ktunnel/ktunnel Updating Homebrew... ==> Auto-updated Homebrew! Updated 3 taps (omrikiei/ktunnel, homebrew/core and homebrew/cask). ==> New Formulae age bbtools cosign cppzmq fann flamebearer htmlq libmng microsocks mimalloc murex osc-cli solana ==> Updated Formulae Updated 603 formulae. ==> New Casks archi far2l ==> Updated Casks Updated 120 casks.

==> Downloading https://github.com/omrikiei/ktunnel/releases/download/v1.4.3/ktunnel_1.4.3_Darwin_x86_64.tar.gz ==> Downloading from https://github-releases.githubusercontent.com/210868522/3273abe2-72b6-4e4f-8b3a-38dbf064be16?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20210910%2Fus-east-1%2Fs3%2Faws4_request&X-A ######################################################################## 100.0% ==> Installing ktunnel from omrikiei/ktunnel ktunnel 1.4.0 is installed but outdated ==> Upgrading omrikiei/ktunnel/ktunnel 1.4.0 -> 1.4.3

🍺 /usr/local/Cellar/ktunnel/1.4.3: 5 files, 33.7MB, built in 7 seconds Removing: /usr/local/Cellar/ktunnel/1.4.0... (5 files, 33.7MB) Removing: /Users/.../Library/Caches/Homebrew/ktunnel--1.4.0.tar.gz... (9.6MB)`

option "-r" is now working.

Many thanks. Please close this issue if you want :)

omrikiei commented 3 years ago

@cblims will take a look at Chocolately - if you know how to add support for it could be great if you add it. Closing the issue

omrikiei / ktunnel

unknown shorthand flag: 'r' in -r #65