omrilotan / isbot

🤖/👨‍🦰 Detect bots/crawlers/spiders using the user agent string
https://isbot.js.org/
The Unlicense
905 stars 74 forks source link

Add Speedcurve #210

Closed 0x7f closed 1 year ago

0x7f commented 1 year ago

Adds two support for Speedcurve user agent. We found two entries in our logs, which I added to the fixtures as well.

They use PTST/SpeedCurve/230120.120134 as the identifier. There is already one for ptst: https://github.com/omrilotan/isbot/blob/40cac9f9804afae59d98d8bcec012c4394e7f40b/src/list.json#L140

But it requires a number after a space or slash. I decided against extending that regexp and instead add a dedicated one for speedcurve in case they start using different identifiers in the future. Hope you agree. If not, I'm happy to adapt the ptst regexp as well.

omrilotan commented 1 year ago

Looks perfect, thank you

omrilotan commented 1 year ago

Thanks, again. Released in version 3.6.8

0x7f commented 1 year ago

@omrilotan thank you very much :)

andydavies commented 1 year ago

Just an FYI, unless a customer overrides it our UA string will always contain PTST/SpeedCurve but the version number after will change over time

omrilotan commented 1 year ago

Thanks, @andydavies. We're not depending on a specific version number but the inclusion of the "speedcurve" substring, so I think we're covered.