Support phantom.app user agent

omrilotan / isbot

🤖/👨‍🦰 Detect bots/crawlers/spiders using the user agent string

https://isbot.js.org/

The Unlicense

876 stars 72 forks source link

Support phantom.app user agent #249

Closed kunalmodi closed 4 months ago

kunalmodi commented 4 months ago

https://github.com/omrilotan/isbot/pull/209 was a little permissive, and blocks popular mobile application https://phantom.app/. Hoping we could restrict the pattern to just PhantomJS to allow Phantom.app traffic to not be recognized as a bot

kunalmodi commented 4 months ago

CI Failure seems unrelated to my exact change as far as I can tell (something about Ecosia). I had a clean run locally with npm run build && npm run prepare && npm run test

omrilotan commented 4 months ago

Nice one, thank you. Does phantomjs ever have that dot? I've never encountered it

kunalmodi commented 4 months ago

Ah good call, I saw Phantom.JS but didn't notice it had "bot" in it as well. Thanks for your help fixing this and getting it in!

omrilotan commented 4 months ago

I appreciate your contribution. This change is included in version 5.1.3